doc: Add a snippet on how people can use 3.8 now onwards #3502
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by providing a clear example for users who need to continue utilizing Python 3.8. It addresses potential breaking changes related to Python version support by offering a direct method to specify and manage Python 3.8 toolchains, ensuring continuity for projects dependent on this version. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a documentation snippet to the changelog, explaining how users can continue to use Python 3.8 after its default toolchains are removed. The snippet demonstrates the use of python.single_version_override. My feedback focuses on improving the clarity of the example to prevent user confusion, as it currently uses placeholder values for the Python version, release URL, and hashes.
| them back. This means any hub `pip.parse` calls that target `3.8` will be ignored from | ||
| now on. ([#2704](https://github.com/bazel-contrib/rules_python/issues/2704)) | ||
| {object}`python.single_version_override`, like: | ||
|
|
There was a problem hiding this comment.
The example snippet uses a non-existent Python version (3.8.20) and a future release date for python-build-standalone. This could be confusing for users who try to copy-paste it. To avoid confusion, it would be helpful to add a note clarifying that the values are placeholders and need to be replaced with actual ones from a python-build-standalone release.
| > **Note**: The following snippet uses placeholder values. Please use a real Python 3.8.x version, URL, and hashes from [python-build-standalone releases](https://github.com/astral-sh/python-build-standalone/releases). |
Thanks to Ted Kaplan (@thirtyseven) for the snippet. (cherry picked from commit ffb7001)
2 participants
Thanks to Ted Kaplan (@thirtyseven) for the snippet.